LGTM with a few style nits.
I like the plan and I don't like the current intermediate state. Let's get
to
the final picture faster.
It's right that accessing the current context and the frame pointer are
performance critical things. The fewer indirections we have the better.
-- Vitaly
http://codereview.chromium.org/2720005/diff/9001/10006
File src/top.cc (right):
http://codereview.chromium.org/2720005/diff/9001/10006#newcode52
src/top.cc:52: #define C(name) top_addresses_[Top::k_##name] =
\
Preprocessor directives should be in the first column.
http://codereview.chromium.org/2720005/diff/9001/10006#newcode60
src/top.cc:60: inline void preallocated_memory_thread_start();
Function names should be use camel case.
http://codereview.chromium.org/2720005/diff/9001/10006#newcode73
src/top.cc:73: TopState top_state;
For clarity (even though this thing is temporary):
1. Add a TODO(isolates) that we're going to move it to isolate ASAP.
2. Missing "static".
http://codereview.chromium.org/2720005/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
