http://codereview.chromium.org/2720005/diff/9001/10004 File src/isolate.h (right):
http://codereview.chromium.org/2720005/diff/9001/10004#newcode46 src/isolate.h:46: public: On 2010/06/11 12:45:35, Maxim.Mossienko wrote:
To avoid cluttering this class I think it is better to have this class
in
original location but without BASE_EMBEDDED
I want the members to be accessible from Isolate without an added indirection cost. http://codereview.chromium.org/2720005/diff/9001/10006 File src/top.cc (right): http://codereview.chromium.org/2720005/diff/9001/10006#newcode73 src/top.cc:73: TopState top_state; On 2010/06/11 12:45:35, Maxim.Mossienko wrote:
We should clone this state per isolate or have many TODOs for locks
for
accessing shared state.
Coming in a future CL. http://codereview.chromium.org/2720005/diff/9001/10006#newcode877 src/top.cc:877: MessageLocation potential_computed_location; On 2010/06/11 12:45:35, Maxim.Mossienko wrote:
The code will benefit from local variable 'thread_local'
It's probably headed to Isolate anyhow, so that'll become thread_local_top. http://codereview.chromium.org/2720005/diff/9001/10006#newcode923 src/top.cc:923: setup_external_caught(); On 2010/06/11 12:45:35, Maxim.Mossienko wrote:
local variable for thread_local() would be nice
Ditto from above. http://codereview.chromium.org/2720005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
