First of all you should convey the information on
the actual break point as both line and column
I think Storing SourceLocation should be appropriate here.
and I think we should consider
including the information in the response to the setbreakpoint request.
Let me introduce this in a separate patch.
Also in
the case where setbreakpoint is called with a type other than 'scriptId'
we
need
to do something. For type 'function' and 'handle' at most one break point
will
be set, but for type 'script' there might be several different scripts
with
the
same name resulting in several actual break points with different actual
locations.
Not sure how to implement this, probably we should add actual_locations
array to
ScriptBreakPoint?
Also adding information in the AfterCompile event on break points created
when
UpdateScriptBreakPoints was called should be considered. For the
listbreakpoints
request adding information on which actual break points have been added
and
there actual positions will also be useful.
Let me introduce this in a separate patch as well.
http://codereview.chromium.org/2859003/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
