http://codereview.chromium.org/2859003/diff/1/2 File src/debug-debugger.js (right):
http://codereview.chromium.org/2859003/diff/1/2#newcode387 src/debug-debugger.js:387: if (pos === null) return -1; On 2010/06/15 09:37:16, Søren Gjesse wrote:
Please define a constant for -1.
Done. http://codereview.chromium.org/2859003/diff/1/2#newcode393 src/debug-debugger.js:393: if (pos === undefined) return -1; On 2010/06/15 09:37:16, Søren Gjesse wrote:
Please use the macro IS_UNDEFINED here (found in macros.py)
Done. http://codereview.chromium.org/2859003/diff/1/2#newcode395 src/debug-debugger.js:395: return script.lineFromPosition(pos); On 2010/06/15 09:37:16, Søren Gjesse wrote:
Please keep track of both line and column of the actual position.
Done. http://codereview.chromium.org/2859003/diff/1/5 File src/runtime.cc (right): http://codereview.chromium.org/2859003/diff/1/5#newcode9133 src/runtime.cc:9133: // args[2]: number: break point object On 2010/06/15 09:37:16, Søren Gjesse wrote:
Please add comment on the return value.
Done. http://codereview.chromium.org/2859003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
