LGTM with loop fixed.
http://codereview.chromium.org/2818026/diff/1/2 File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/2818026/diff/1/2#newcode381 src/x64/assembler-x64.cc:381: nop(9); if delta is >= 9 this will never terminate http://codereview.chromium.org/2818026/diff/1/3 File src/x64/assembler-x64.h (right): http://codereview.chromium.org/2818026/diff/1/3#newcode58 src/x64/assembler-x64.h:58: static inline bool uint_is_int32(uint64_t x) { is_int32 to be consistent with the other methods? http://codereview.chromium.org/2818026/diff/1/3#newcode60 src/x64/assembler-x64.h:60: return x < kMaxIntValue; <= ? http://codereview.chromium.org/2818026/diff/1/3#newcode67 src/x64/assembler-x64.h:67: Maybe use the same naming convention for the max and min values in the four methods above (e.g., kMaxUInt32, kMinInt32, kMaxInt32). http://codereview.chromium.org/2818026/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
