http://codereview.chromium.org/2818026/diff/1/2 File src/x64/assembler-x64.cc (right):
http://codereview.chromium.org/2818026/diff/1/2#newcode381 src/x64/assembler-x64.cc:381: nop(9); Whoops, fixed. http://codereview.chromium.org/2818026/diff/1/3 File src/x64/assembler-x64.h (right): http://codereview.chromium.org/2818026/diff/1/3#newcode58 src/x64/assembler-x64.h:58: static inline bool uint_is_int32(uint64_t x) { It differs from the other methods in that its argument doesn't allow all the possible values that it could accept (negative int32's cannot be passed). I think this was the reason for the different naming, but I can see it's not obvious why it's named differently. http://codereview.chromium.org/2818026/diff/1/3#newcode60 src/x64/assembler-x64.h:60: return x < kMaxIntValue; Changed, and value changed to 0x7fffffff. http://codereview.chromium.org/2818026/diff/1/3#newcode67 src/x64/assembler-x64.h:67: Done. http://codereview.chromium.org/2818026/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
