LGTM.
Does it apply in more cases? E.g. GenerateMathPow where one of the operands
is
often a constant, and I'm guessing the left operand is most likely to be
one.
http://codereview.chromium.org/2868028/diff/3001/4001
File src/x64/codegen-x64.cc (right):
http://codereview.chromium.org/2868028/diff/3001/4001#newcode3839
src/x64/codegen-x64.cc:3839: Load(right);
The optimization is likely to apply here too, because left is almost
certainly a literal string.
http://codereview.chromium.org/2868028/diff/3001/4001#newcode3846
src/x64/codegen-x64.cc:3846: Load(right);
... but it's probably not worth it here, since left should be an object.
http://codereview.chromium.org/2868028/diff/3001/4001#newcode3863
src/x64/codegen-x64.cc:3863: frame_->Push(&right_result);
Could we reverse the comparison instead, and keep left on top of the
stack?
http://codereview.chromium.org/2868028/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
