http://codereview.chromium.org/2868028/diff/3001/4001 File src/x64/codegen-x64.cc (right):
http://codereview.chromium.org/2868028/diff/3001/4001#newcode3839 src/x64/codegen-x64.cc:3839: Load(right); On 2010/06/24 08:59:48, Lasse Reichstein wrote:
The optimization is likely to apply here too, because left is almost
certainly a
literal string.
But since we are going to a builtin, it will be spilled anyway. http://codereview.chromium.org/2868028/diff/3001/4001#newcode3863 src/x64/codegen-x64.cc:3863: frame_->Push(&right_result); On 2010/06/24 08:59:48, Lasse Reichstein wrote:
Could we reverse the comparison instead, and keep left on top of the
stack? I don't think so, because the ToNumber calls inside comparison have to happen in a certain order. http://codereview.chromium.org/2868028/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
