Reviewers: Vitaly, Dmitry Titov,
Message:
Almost through all the symbols!
Thanks
Luke
Description:
[Isolates] Moved more compilation-related globals (builtins, runtime, &c.)
Most changes are mechanical. This CL and the previous CL were built by
choosing static symbols from libv8_g.a and lifting them to Isolate. The
effects on the codebase as a whole are difficult to predict (eg, adding
const to ensure that Runtime::Function*s aren't modified hits a bunch of
files,
but fixing up the pretty printer is self-contained).
--------------------------------------------------------------------------------
isolate.h / isolate.cc (as always).
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
builtins.h, builtins.cc
--------------------------------------------------------------------------------
The old Isolate::builtins() was renamed to js_builtins_object().
Per-isolate data (generated code) moved to Isolate; global data
(eg, javascript_argc_) kept in place.
builtins.cc:1436: Is there any danger of running out of stack here?
--------------------------------------------------------------------------------
codegen.cc, */codegen-*.h, runtime.h
--------------------------------------------------------------------------------
Runtime::Function* accessors were made to return const pointers.
kInlineRuntimeLUT is actually non-constant (it can be patched); moved it
to Isolate.
Statics from runtime.cc moved into RuntimeState class.
--------------------------------------------------------------------------------
liveedit.h, liveedit.cc:
--------------------------------------------------------------------------------
-> active_function_info_listener
-> liveedit_compare_substrings_buf1
-> liveedit_compare_substrings_buf2
LiveEditFunctionTracker now takes a pointer to an Isolate but keeps it
around only in debug builds.
--------------------------------------------------------------------------------
vm-state.h, vm-state.cc, vm-state-inl.h:
--------------------------------------------------------------------------------
-> vm_state
--------------------------------------------------------------------------------
compiler.cc:
--------------------------------------------------------------------------------
-> compiler_safe_string_input_buffer
--------------------------------------------------------------------------------
assembler.h:
--------------------------------------------------------------------------------
-> external_reference_redirector
--------------------------------------------------------------------------------
ast.h, ast.cc, parser.cc:
--------------------------------------------------------------------------------
-> always_allow_natives_syntax
moved various sentinels to AstSentinels class (it was unclear that
these things were being used as constants.)
--------------------------------------------------------------------------------
prettyprinter.h, prettyprinter.cc:
--------------------------------------------------------------------------------
Unnecessary global moved to instance variable (no need to touch Isolate).
--------------------------------------------------------------------------------
Simple replacement/const+:
--------------------------------------------------------------------------------
arm/builtins-arm.cc
arm/codegen-arm.cc
arm/full-codegen-arm.cc
arm/macro-assembler-arm.h
arm/macro-assembler-arm.cc
arm/stub-cache-arm.cc
arm/virtual-frame-arm.h
arm/virtual-frame-arm.cc
assembler.cc
bootstrapper.cc
debug.cc
disassembler.cc
execution.cc
factory.cc
frames.cc
heap.cc
ia32/builtins-ia32.cc
ia32/codegen-ia32.cc
ia32/full-codegen-ia32.cc
ia32/macro-assembler-ia32.h
ia32/macro-assembler-ia32.cc
ia32/stub-cache-ia32.cc
ia32/virtual-frame-ia32.h
ia32/virtual-frame-ia32.cc
ic.h
ic.cc
messages.cc
stub-cache.cc
top.cc
x64/builtins-x64.cc
x64/codegen-x64.cc
x64/macro-assembler-x64.h
x64/macro-assembler-x64.cc
x64/stub-cache-x64.cc
x64/virtual-frame-x64.h
x64/virtual-frame-x64.cc
test-alloc.cc
test-debug.cc
test-disasm-ia32.cc
test-log-stack-tracker.cc
Please review this at http://codereview.chromium.org/2840018/show
SVN Base: http://v8.googlecode.com/svn/branches/experimental/isolates/
Affected files:
M src/api.cc
M src/arm/builtins-arm.cc
M src/arm/codegen-arm.h
M src/arm/codegen-arm.cc
M src/arm/full-codegen-arm.cc
M src/arm/macro-assembler-arm.h
M src/arm/macro-assembler-arm.cc
M src/arm/stub-cache-arm.cc
M src/arm/virtual-frame-arm.h
M src/arm/virtual-frame-arm.cc
M src/assembler.h
M src/assembler.cc
M src/ast.h
M src/ast.cc
M src/bootstrapper.cc
M src/builtins.h
M src/builtins.cc
M src/codegen.cc
M src/compiler.cc
M src/debug.cc
M src/disassembler.cc
M src/execution.cc
M src/factory.cc
M src/frames.cc
M src/heap.cc
M src/ia32/builtins-ia32.cc
M src/ia32/codegen-ia32.h
M src/ia32/codegen-ia32.cc
M src/ia32/full-codegen-ia32.cc
M src/ia32/macro-assembler-ia32.h
M src/ia32/macro-assembler-ia32.cc
M src/ia32/stub-cache-ia32.cc
M src/ia32/virtual-frame-ia32.h
M src/ia32/virtual-frame-ia32.cc
M src/ic.h
M src/ic.cc
M src/isolate.h
M src/isolate.cc
M src/liveedit.h
M src/liveedit.cc
M src/messages.cc
M src/parser.cc
M src/prettyprinter.h
M src/prettyprinter.cc
M src/runtime.h
M src/runtime.cc
M src/stub-cache.cc
M src/top.cc
M src/vm-state-inl.h
M src/vm-state.h
M src/vm-state.cc
M src/x64/builtins-x64.cc
M src/x64/codegen-x64.h
M src/x64/codegen-x64.cc
M src/x64/full-codegen-x64.cc
M src/x64/macro-assembler-x64.h
M src/x64/macro-assembler-x64.cc
M src/x64/stub-cache-x64.cc
M src/x64/virtual-frame-x64.h
M src/x64/virtual-frame-x64.cc
M test/cctest/test-alloc.cc
M test/cctest/test-debug.cc
M test/cctest/test-disasm-ia32.cc
M test/cctest/test-log-stack-tracer.cc
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
