Reviewers: Michail Naganov, Søren Gjesse, Description: Fix 15.2.3.4 es5conform test
TBR=mnaganov,sgjesse Please review this at http://codereview.chromium.org/2832029/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/v8natives.js M test/cctest/test-api.cc Index: src/v8natives.js =================================================================== --- src/v8natives.js (revision 4958) +++ src/v8natives.js (working copy) @@ -682,7 +682,10 @@ var j = 0; for (var i = 0; i < propertyNames.length; ++i) { var name = ToString(propertyNames[i]); - if (name in propertySet) + // We need to check for the exact property value since for intrinsic + // properties like toString if(propertySet["toString"]) will always + // succeed. + if (propertySet[name] === true) continue; propertySet[name] = true; propertyNames[j++] = name; Index: test/cctest/test-api.cc =================================================================== --- test/cctest/test-api.cc (revision 4958) +++ test/cctest/test-api.cc (working copy) @@ -5049,7 +5049,7 @@ obj_template->Set(v8_str("x"), v8::Integer::New(42)); obj_template->SetNamedPropertyHandler(NULL, NULL, NULL, NULL, NamedPropertyEnumerator); - + LocalContext context; v8::Handle<v8::Object> global = context->Global(); global->Set(v8_str("object"), obj_template->NewInstance()); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
