Revision: 4959 Author: [email protected] Date: Mon Jun 28 02:25:09 2010 Log: Fix 15.2.3.4 es5conform test
TBR=mnaganov,sgjesse Review URL: http://codereview.chromium.org/2832029 http://code.google.com/p/v8/source/detail?r=4959 Modified: /branches/bleeding_edge/src/v8natives.js /branches/bleeding_edge/test/cctest/test-api.cc ======================================= --- /branches/bleeding_edge/src/v8natives.js Mon Jun 28 01:31:31 2010 +++ /branches/bleeding_edge/src/v8natives.js Mon Jun 28 02:25:09 2010 @@ -682,7 +682,10 @@ var j = 0; for (var i = 0; i < propertyNames.length; ++i) { var name = ToString(propertyNames[i]); - if (name in propertySet) + // We need to check for the exact property value since for intrinsic + // properties like toString if(propertySet["toString"]) will always + // succeed. + if (propertySet[name] === true) continue; propertySet[name] = true; propertyNames[j++] = name; ======================================= --- /branches/bleeding_edge/test/cctest/test-api.cc Mon Jun 28 01:31:31 2010 +++ /branches/bleeding_edge/test/cctest/test-api.cc Mon Jun 28 02:25:09 2010 @@ -5049,7 +5049,7 @@ obj_template->Set(v8_str("x"), v8::Integer::New(42)); obj_template->SetNamedPropertyHandler(NULL, NULL, NULL, NULL, NamedPropertyEnumerator); - + LocalContext context; v8::Handle<v8::Object> global = context->Global(); global->Set(v8_str("object"), obj_template->NewInstance()); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
