LGTM

http://codereview.chromium.org/2840023/diff/1/3
File test/es5conform/es5conform.status (right):

http://codereview.chromium.org/2840023/diff/1/3#newcode39
test/es5conform/es5conform.status:39: # We are compatible with safary
and firefox.
Safari and Firefox

http://codereview.chromium.org/2840023/diff/1/3#newcode91
test/es5conform/es5conform.status:91: # Our Function object has a
"arguments" property which is used as a non
has a -> has an
non property -> non-property

http://codereview.chromium.org/2840023/diff/1/3#newcode96
test/es5conform/es5conform.status:96: # property in in the test.
non property and again below.

http://codereview.chromium.org/2840023/diff/1/3#newcode230
test/es5conform/es5conform.status:230: # is no longer traversed.
Is this a wrong test?

http://codereview.chromium.org/2840023/diff/1/3#newcode252
test/es5conform/es5conform.status:252: # entries are added for non
existing entries smaller than lenght by
lenght -> length
non-existing -> nonexistent

http://codereview.chromium.org/2840023/diff/1/3#newcode257
test/es5conform/es5conform.status:257: # Wrong tests, path in test file
is wrong. This will chrash the test
chrash -> crash

http://codereview.chromium.org/2840023/diff/1/3#newcode275
test/es5conform/es5conform.status:275: # RegExp.prototype is not of type
RegExp - we are bug compatible with safari.
safari -> JSC
or Safari
and again below

http://codereview.chromium.org/2840023/diff/1/3#newcode291
test/es5conform/es5conform.status:291: # See
http://code.google.com/p/v8/issues/detail?id=753
Please add a couple of words on the subject of the bug to jog people's
memory.

http://codereview.chromium.org/2840023/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to