http://codereview.chromium.org/2799037/diff/1/2 File src/debug-debugger.js (right):
http://codereview.chromium.org/2799037/diff/1/2#newcode400 src/debug-debugger.js:400: if (IS_UNDEFINED(actual_position)) { On 2010/06/28 06:50:30, Søren Gjesse wrote:
Is this undefined check still needed after the change to runtime.cc?
Yes, because Runtime_SetScriptBreakPoint returns undefined in case no SharedFunctionInfo is available for the given position. http://codereview.chromium.org/2799037/diff/1/2#newcode613 src/debug-debugger.js:613: var pos = %SetFunctionBreakPoint(func, source_position, break_point); On 2010/06/28 06:50:30, Søren Gjesse wrote:
Maybe pos -> actual_position as above
Done. http://codereview.chromium.org/2799037/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
