Reviewers: Lasse Reichstein,
Description:
Update JSON.stringify to floor the space parameter (fixes issue 753).
Please review this at http://codereview.chromium.org/2877004/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/json.js
M test/es5conform/es5conform.status
A test/mjsunit/regress/regress-753.js
Index: src/json.js
===================================================================
--- src/json.js (revision 4949)
+++ src/json.js (working copy)
@@ -241,7 +241,7 @@
}
var gap;
if (IS_NUMBER(space)) {
- space = $Math.min(space, 10);
+ space = $Math.min($Math.floor(space), 10);
gap = "";
for (var i = 0; i < space; i++) {
gap += " ";
Index: test/es5conform/es5conform.status
===================================================================
--- test/es5conform/es5conform.status (revision 4970)
+++ test/es5conform/es5conform.status (working copy)
@@ -284,11 +284,6 @@
chapter15/15.10/15.10.7/15.10.7.5/15.10.7.5-1: FAIL_OK
chapter15/15.10/15.10.7/15.10.7.5/15.10.7.5-2: FAIL_OK
-# JSON.stringify does not correctly truncate the space parameter.
-# See http://code.google.com/p/v8/issues/detail?id=753
-chapter15/15.12/15.12.3/15.12.3-6-a-2: FAIL_OK
-chapter15/15.12/15.12.3/15.12.3-6-b-1: FAIL_OK
-
[ $arch == mips ]
# Skip all tests on MIPS.
Index: test/mjsunit/regress/regress-753.js
===================================================================
--- test/mjsunit/regress/regress-753.js (revision 0)
+++ test/mjsunit/regress/regress-753.js (revision 0)
@@ -0,0 +1,36 @@
+// Copyright 2010 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+// * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+// * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following
+// disclaimer in the documentation and/or other materials provided
+// with the distribution.
+// * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived
+// from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// Test that JSON.stringify correctly truncates floating point numbers.
+// This test is based on chapter15/15.12/15.12.3/15.12.3-6-a-2.js in the
+// ES5 conformance tests.
+
+// See: http://code.google.com/p/v8/issues/detail?id=753
+
+var obj = {a1: {b1: [1,2,3,4], b2: {c1: 1, c2: 2}},a2: 'a2'};
+assertEquals(JSON.stringify(obj,null, 5.99999), JSON.stringify(obj,null,
5));
+
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
