LGTM
http://codereview.chromium.org/2877004/diff/5001/6001 File src/json.js (right): http://codereview.chromium.org/2877004/diff/5001/6001#newcode244 src/json.js:244: space = $Math.min($Math.floor(space), 10); According to spec we should us ToInteger here. This gives the same result, though, since we still do nothing on negative numbers and NaN (where floor differes from ToInteger). http://codereview.chromium.org/2877004/diff/5001/6002 File test/es5conform/es5conform.status (right): http://codereview.chromium.org/2877004/diff/5001/6002#newcode64 test/es5conform/es5conform.status:64: chapter15/15.2/15.2.3/15.2.3.3/15.2.3.3-4-20: FAIL_OK Why isn't this UNIMPLEMENTED instead of FAIL_OK? FAIL_OK suggests that we are not interested in fixing it, ever (we fail, and it's ok). http://codereview.chromium.org/2877004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
