LGTM
Address these comments and let's land this. Please port to x64 and arm next
so
we can get rid of the ifdef.
http://codereview.chromium.org/2801018/diff/31022/77007
File src/ia32/stub-cache-ia32.cc (right):
http://codereview.chromium.org/2801018/diff/31022/77007#newcode153
src/ia32/stub-cache-ia32.cc:153: // If names of slots in range [0...n -
1) for the hash value are not
n -> kProbes.
http://codereview.chromium.org/2801018/diff/31022/77007#newcode154
src/ia32/stub-cache-ia32.cc:154: // equal to the name and slot n is not
used (its name is the undefined value),
n -> kProbes - 1?
http://codereview.chromium.org/2801018/diff/31022/77007#newcode831
src/ia32/stub-cache-ia32.cc:831: // [object, holder).
This notation does not make sense for objects.
for each global object in the prototype chain from object to (but not
including) holder.
?
http://codereview.chromium.org/2801018/diff/31022/77007#newcode858
src/ia32/stub-cache-ia32.cc:858: static void
GenerateCheckPropertyHolder(MacroAssembler* masm,
I don't think this abstraction makes sense and definitely not with this
name. Please inline again or come up with a more descriptive name.
http://codereview.chromium.org/2801018/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
