http://codereview.chromium.org/2801018/diff/31022/77007 File src/ia32/stub-cache-ia32.cc (right):
http://codereview.chromium.org/2801018/diff/31022/77007#newcode153 src/ia32/stub-cache-ia32.cc:153: // If names of slots in range [0...n - 1) for the hash value are not On 2010/07/02 10:39:41, Mads Ager wrote:
n -> kProbes.
Done. http://codereview.chromium.org/2801018/diff/31022/77007#newcode154 src/ia32/stub-cache-ia32.cc:154: // equal to the name and slot n is not used (its name is the undefined value), On 2010/07/02 10:39:41, Mads Ager wrote:
n -> kProbes - 1?
Done. http://codereview.chromium.org/2801018/diff/31022/77007#newcode831 src/ia32/stub-cache-ia32.cc:831: // [object, holder). On 2010/07/02 10:39:41, Mads Ager wrote:
This notation does not make sense for objects.
for each global object in the prototype chain from object to (but not
including)
holder.
?
Done. http://codereview.chromium.org/2801018/diff/31022/77007#newcode858 src/ia32/stub-cache-ia32.cc:858: static void GenerateCheckPropertyHolder(MacroAssembler* masm, On 2010/07/02 10:39:41, Mads Ager wrote:
I don't think this abstraction makes sense and definitely not with
this name.
Please inline again or come up with a more descriptive name.
Done. http://codereview.chromium.org/2801018/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
