Drive-by whining.
http://codereview.chromium.org/2841041/diff/5001/6001 File src/date.js (right): http://codereview.chromium.org/2841041/diff/5001/6001#newcode897 src/date.js:897: date = %_ArgumentsLength() < 2 ? %_CallFunction(this, DateGetUTCDate) : ToNumber(date); The DateGetUTCDate function is externally available, and is also called internally. I consider that a code smell, because it means that the function serves two purposes - satisfying the interface and being a sub-computation of another function (which is also why you need to use CallFunction - it doesn't have the signature of a helper function, so you need to circumvent that). However, I also don't like code duplication, so inlining it in both places isn't a good idea either. I think I actually prefer the helper function used in both places. (For the functions that aren't reused, inlining is fine). http://codereview.chromium.org/2841041/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
