There is still a slight duplication of NaN handling but I thinks it is unavoidable.
LGTM http://codereview.chromium.org/2841041/diff/9001/10002 File src/macros.py (right): http://codereview.chromium.org/2841041/diff/9001/10002#newcode157 src/macros.py:157: macro NAN_OR_MS_FROM_TIME(time) = (NUMBER_IS_NAN(time) ? time: (Modulo(time, 1000))); define in terms of MS_FROM_TIME? whitespace before colon http://codereview.chromium.org/2841041/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
