Please add a test case in test-api.cc that checks that you get the right
kind of
exception when passing in malformed preparsing data.
http://codereview.chromium.org/2876046/diff/1/2
File src/parser.cc (right):
http://codereview.chromium.org/2876046/diff/1/2#newcode3820
src/parser.cc:3820: ReportMessage("invalid preparser data", Vector<const
char*>::empty());
Please refactor this code and introduce a new helper function for
reporting invalid preparsing data. I agree with Kevin that you want this
match something in messages.js and that you should include the position
or something (maybe both the source position and the position in the
preparsing data).
http://codereview.chromium.org/2876046/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
