LGTM.
http://codereview.chromium.org/2876046/diff/19001/20002 File src/parser.cc (right): http://codereview.chromium.org/2876046/diff/19001/20002#newcode137 src/parser.cc:137: void ReportInvalidPreparseData(Handle<String> name, bool *ok); bool *ok => bool* ok http://codereview.chromium.org/2876046/diff/19001/20003 File test/cctest/test-api.cc (right): http://codereview.chromium.org/2876046/diff/19001/20003#newcode8571 test/cctest/test-api.cc:8571: // ScriptDataImpl private implementation details I agree that this is not pretty, but it's much better than no testing. Thanks. Feel free to clean it up in a separate CL. http://codereview.chromium.org/2876046/diff/19001/20003#newcode8591 test/cctest/test-api.cc:8591: compiled_script = Script::New(source, NULL, sd); You should really be running the compiled script and/or catching the exception here. Please make sure you get the right exception. http://codereview.chromium.org/2876046/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
