LGTM except that I'm not so keen on the code duplication. Can't we just
add the
register arguments to all architectures and give them a default of no_reg.
It could well be that we should be using register passing on the other
architectures too (not for this change).
http://codereview.chromium.org/2850046/diff/1/2
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/2850046/diff/1/2#newcode7468
src/arm/codegen-arm.cc:7468: // On entry r0 (rhs) and r1 (lhs) are the
values to be compared.
Comment needs updating.
http://codereview.chromium.org/2850046/diff/1/3
File src/arm/codegen-arm.h (right):
http://codereview.chromium.org/2850046/diff/1/3#newcode656
src/arm/codegen-arm.h:656: // Encoding of the minor key
CCCCCCCCCCCCCCNS.
Looks like this comment hasn't been updated for the
IncludeNumberCompareField and the Register field.
http://codereview.chromium.org/2850046/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
