new version sharing CompareStub definition across all archs and using no_reg when the option is meaningless.
http://codereview.chromium.org/2850046/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2850046/diff/1/2#newcode7468 src/arm/codegen-arm.cc:7468: // On entry r0 (rhs) and r1 (lhs) are the values to be compared. On 2010/07/07 18:33:02, Erik Corry wrote:
Comment needs updating.
Done. http://codereview.chromium.org/2850046/diff/1/3 File src/arm/codegen-arm.h (right): http://codereview.chromium.org/2850046/diff/1/3#newcode656 src/arm/codegen-arm.h:656: // Encoding of the minor key CCCCCCCCCCCCCCNS. On 2010/07/07 18:33:02, Erik Corry wrote:
Looks like this comment hasn't been updated for the
IncludeNumberCompareField
and the Register field.
Done. http://codereview.chromium.org/2850046/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
