http://codereview.chromium.org/2860049/diff/51001/52003 File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/2860049/diff/51001/52003#newcode108 src/arm/stub-cache-arm.cc:108: Remove blank line or have the blank line before the comment. http://codereview.chromium.org/2860049/diff/51001/52003#newcode115 src/arm/stub-cache-arm.cc:115: if (extra.is(no_reg)) { Add a // Check that receiver is a JSObject. comment? http://codereview.chromium.org/2860049/diff/51001/52003#newcode132 src/arm/stub-cache-arm.cc:132: Register tmp1 = receiver, tmp2 = properties; Could you use two lines please? http://codereview.chromium.org/2860049/diff/51001/52003#newcode138 src/arm/stub-cache-arm.cc:138: __ b(ne, miss_label); Remove, this is emitted after the conditional. http://codereview.chromium.org/2860049/diff/51001/52003#newcode200 src/arm/stub-cache-arm.cc:200: // Restore the properties if their register was occupied by the name. There is no conditional here. Either update the comment or make the reloading of the properties array guarded by extra.is(no_reg)? http://codereview.chromium.org/2860049/diff/51001/52008 File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/2860049/diff/51001/52008#newcode94 src/x64/stub-cache-x64.cc:94: Register extra) { I would guess that you do not need any of the checks for extra on x64 and arm? You should have enough registers on those platforms to always pass in an extra register and just assert at the top that extra is not no_reg. http://codereview.chromium.org/2860049/diff/51001/52008#newcode109 src/x64/stub-cache-x64.cc:109: __ CmpInstanceType(r0, FIRST_JS_OBJECT_TYPE); Add short "Check that receiver is a JSObject" comment here on all platforms? http://codereview.chromium.org/2860049/diff/51001/52008#newcode146 src/x64/stub-cache-x64.cc:146: __ SmiToInteger64(index, FieldOperand(properties, kCapacityOffset)); SmiToInteger32? http://codereview.chromium.org/2860049/diff/51001/52008#newcode147 src/x64/stub-cache-x64.cc:147: __ decq(index); decl? http://codereview.chromium.org/2860049/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
