http://codereview.chromium.org/2860049/diff/51001/52003 File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/2860049/diff/51001/52003#newcode108 src/arm/stub-cache-arm.cc:108: On 2010/07/12 10:42:57, Mads Ager wrote:
Remove blank line or have the blank line before the comment.
Done. http://codereview.chromium.org/2860049/diff/51001/52003#newcode115 src/arm/stub-cache-arm.cc:115: if (extra.is(no_reg)) { On 2010/07/12 10:42:57, Mads Ager wrote:
Add a
// Check that receiver is a JSObject.
comment?
Done. http://codereview.chromium.org/2860049/diff/51001/52003#newcode132 src/arm/stub-cache-arm.cc:132: Register tmp1 = receiver, tmp2 = properties; On 2010/07/12 10:42:57, Mads Ager wrote:
Could you use two lines please?
Done. http://codereview.chromium.org/2860049/diff/51001/52003#newcode138 src/arm/stub-cache-arm.cc:138: __ b(ne, miss_label); On 2010/07/12 10:42:57, Mads Ager wrote:
Remove, this is emitted after the conditional.
Done. http://codereview.chromium.org/2860049/diff/51001/52003#newcode200 src/arm/stub-cache-arm.cc:200: // Restore the properties if their register was occupied by the name. On 2010/07/12 10:42:57, Mads Ager wrote:
There is no conditional here. Either update the comment or make the
reloading of
the properties array guarded by extra.is(no_reg)?
The comment was outdated. Fixed. http://codereview.chromium.org/2860049/diff/51001/52008 File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/2860049/diff/51001/52008#newcode94 src/x64/stub-cache-x64.cc:94: Register extra) { On 2010/07/12 10:42:57, Mads Ager wrote:
I would guess that you do not need any of the checks for extra on x64
and arm?
You should have enough registers on those platforms to always pass in
an extra
register and just assert at the top that extra is not no_reg.
Actually there is no difference among all of these three platforms. no_reg value is used only in CallInterceptorCompiler instantiated in CallStubCompiler::CompileCallInterceptor, but it seems that in all these cases an additional register could be added. Probably it would worth to do it to simplify GenerateDictionaryNegativeLookup, but I may be in a separate CL? http://codereview.chromium.org/2860049/diff/51001/52008#newcode109 src/x64/stub-cache-x64.cc:109: __ CmpInstanceType(r0, FIRST_JS_OBJECT_TYPE); On 2010/07/12 10:42:57, Mads Ager wrote:
Add short "Check that receiver is a JSObject" comment here on all
platforms? Done. http://codereview.chromium.org/2860049/diff/51001/52008#newcode146 src/x64/stub-cache-x64.cc:146: __ SmiToInteger64(index, FieldOperand(properties, kCapacityOffset)); On 2010/07/12 10:42:57, Mads Ager wrote:
SmiToInteger32?
Done. http://codereview.chromium.org/2860049/diff/51001/52008#newcode147 src/x64/stub-cache-x64.cc:147: __ decq(index); On 2010/07/12 10:42:57, Mads Ager wrote:
decl?
Done. http://codereview.chromium.org/2860049/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
