LGTM
I don't really like the fact that we can now end up traversing the stack
three
times for exceptions (collect stack frames for the error.stack property,
collect
string stack trace, collect stack trace array). However, this is only for
uncaught exceptions so I guess it should never be performance critical.
http://codereview.chromium.org/2961003/diff/32001/16003
File src/api.cc (right):
http://codereview.chromium.org/2961003/diff/32001/16003#newcode1450
src/api.cc:1450: if (!stackFramesObj->IsJSArray())
Please add braces around body.
http://codereview.chromium.org/2961003/diff/32001/16003#newcode1604
src/api.cc:1604: i::Top::CaptureCurrentStackTrace(frame_limit, options);
Indentation off?
http://codereview.chromium.org/2961003/diff/32001/16008
File src/top.cc (right):
http://codereview.chromium.org/2961003/diff/32001/16008#newcode785
src/top.cc:785: void Top::ReportUncaughtException(Handle<Object>
exception,
Hmm, is this one no longer used? If it is used it should capture the
stack trace and if not could you remove it?
http://codereview.chromium.org/2961003/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
