http://codereview.chromium.org/2961003/diff/32001/16003 File src/api.cc (right):
http://codereview.chromium.org/2961003/diff/32001/16003#newcode1450 src/api.cc:1450: if (!stackFramesObj->IsJSArray()) On 2010/07/12 12:25:32, Mads Ager wrote:
Please add braces around body.
Done. http://codereview.chromium.org/2961003/diff/32001/16003#newcode1604 src/api.cc:1604: i::Top::CaptureCurrentStackTrace(frame_limit, options); On 2010/07/12 12:25:32, Mads Ager wrote:
Indentation off?
Done. http://codereview.chromium.org/2961003/diff/32001/16008 File src/top.cc (right): http://codereview.chromium.org/2961003/diff/32001/16008#newcode785 src/top.cc:785: void Top::ReportUncaughtException(Handle<Object> exception, On 2010/07/12 12:25:32, Mads Ager wrote:
Hmm, is this one no longer used? If it is used it should capture the
stack trace
and if not could you remove it?
Removed, it was unused. http://codereview.chromium.org/2961003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
