LGTM.
http://codereview.chromium.org/2000004/diff/19001/14002 File src/fast-dtoa.cc (right): http://codereview.chromium.org/2000004/diff/19001/14002#newcode490 src/fast-dtoa.cc:490: // * w is correct up to 1 ulp (unit in the last place). That What does this mean? w is the input. Isn't it exact? What is "they" - w is a single number. Do you mean w represents a range of numbers between w - ulp and w + ulp? http://codereview.chromium.org/2000004/diff/19001/14002#newcode498 src/fast-dtoa.cc:498: // digit is rounded according to the rest. According to the rest of what? Why not "is rounded correctly" http://codereview.chromium.org/2000004/diff/19001/14002#newcode500 src/fast-dtoa.cc:500: // Isn't |eps| < 10^kappa / 2? http://codereview.chromium.org/2000004/diff/19001/14002#newcode524 src/fast-dtoa.cc:524: uint32_t divider; divisor, rather than divider. http://codereview.chromium.org/2000004/diff/19001/14002#newcode553 src/fast-dtoa.cc:553: kappa); Why do we need to cut off a trailing 0 and reduce kappa by one in this case? Isn't it ok to leave it since we know we want that many digits? http://codereview.chromium.org/2000004/diff/19001/14002#newcode560 src/fast-dtoa.cc:560: // Instead of multiplying by 10 we multiply by 5 (cheaper operation) and Is it really a saving to multiply by 5 rather than 10 in this case? If we don't, then we don't have to manipulate the exponent. http://codereview.chromium.org/2000004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
