LGTM. Comments seem clearer.
http://codereview.chromium.org/2000004/diff/52001/56001 File src/fast-dtoa.cc (right): http://codereview.chromium.org/2000004/diff/52001/56001#newcode216 src/fast-dtoa.cc:216: // exception of the first digit all digits are now '0'. Simply switch the OK, My earlier comment was a misunderstanding - I thought we were reacting to every carry in the last place, not just a carry that propagated all the way to overflow the most significant digit. http://codereview.chromium.org/2000004/diff/52001/56001#newcode518 src/fast-dtoa.cc:518: uint64_t unit = 1; Could this be called precision, or precision_unit, so it is not as easy to confuse with one? "The precision of w, which starts at 1 ulp and scales as we scale w to extract the digits." http://codereview.chromium.org/2000004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
