LGTM if it works.

http://codereview.chromium.org/3082012/diff/1/2
File src/messages.js (right):

http://codereview.chromium.org/3082012/diff/1/2#newcode712
src/messages.js:712: this.receiver.__lookupSetter__(ownName) ===
this.fun ||
Is __lookup[GS]etter__ safe to use, or can it be changed by the user?
Would it be safer to use ES5 Object.getOwnPropertyDescriptor (+ perhaps
prototype traversal) instead?

http://codereview.chromium.org/3082012/diff/1/3
File test/mjsunit/regress/regress-798.js (right):

http://codereview.chromium.org/3082012/diff/1/3#newcode68
test/mjsunit/regress/regress-798.js:68:
Try adding tests where users have changed __defineGetter__.

http://codereview.chromium.org/3082012/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to