LGTM

http://codereview.chromium.org/3101001/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/3101001/diff/1/2#newcode1822
include/v8.h:1822: * The result is true if either boolean (true if
property exists and false
The result is true if either boolean ...
->
The result is either a boolean ...

http://codereview.chromium.org/3101001/diff/1/2#newcode2066
include/v8.h:2066: IndexedPropertyEnumerator enumerator,
Long line.

http://codereview.chromium.org/3101001/diff/1/4
File src/objects.cc (right):

http://codereview.chromium.org/3101001/diff/1/4#newcode5836
src/objects.cc:5836: // Temporary complicated logic, would be removed
soon.
Instead of writing that it will be removed soon, can you write that it
will be removed when then transition to the new signature for indexed
query callbacks is complete.

http://codereview.chromium.org/3101001/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to