LGTM
http://codereview.chromium.org/3117006/diff/15024/24002 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/3117006/diff/15024/24002#newcode4825 src/arm/codegen-arm.cc:4825: __ cmp(map_result_,ip); Space after comma. http://codereview.chromium.org/3117006/diff/15024/24002#newcode4882 src/arm/codegen-arm.cc:4882: Remove these lines? http://codereview.chromium.org/3117006/diff/15024/24002#newcode4893 src/arm/codegen-arm.cc:4893: // Set the bit in the map to indicate that it has been checked safe for Add a line before this comment instead? http://codereview.chromium.org/3117006/diff/15024/24018 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/3117006/diff/15024/24018#newcode6086 src/x64/codegen-x64.cc:6086: Operand(map_result_, index.reg, index.scale, FixedArray::kHeaderSize)); Long line. http://codereview.chromium.org/3117006/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
