http://codereview.chromium.org/3117006/diff/15024/24002 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/3117006/diff/15024/24002#newcode4825 src/arm/codegen-arm.cc:4825: __ cmp(map_result_,ip); On 2010/08/12 13:33:51, Mads Ager wrote:
Space after comma.
Done. http://codereview.chromium.org/3117006/diff/15024/24002#newcode4882 src/arm/codegen-arm.cc:4882: On 2010/08/12 13:33:51, Mads Ager wrote:
Remove these lines?
Done. http://codereview.chromium.org/3117006/diff/15024/24002#newcode4893 src/arm/codegen-arm.cc:4893: // Set the bit in the map to indicate that it has been checked safe for On 2010/08/12 13:33:51, Mads Ager wrote:
Add a line before this comment instead?
Done. http://codereview.chromium.org/3117006/diff/15024/24018 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/3117006/diff/15024/24018#newcode6086 src/x64/codegen-x64.cc:6086: Operand(map_result_, index.reg, index.scale, FixedArray::kHeaderSize)); On 2010/08/12 13:33:51, Mads Ager wrote:
Long line.
Done. http://codereview.chromium.org/3117006/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
