LGTM
Thanks for implementing this utility Anton! This will make OOM investigates
much
easier.
http://codereview.chromium.org/3170015/diff/2001/1004
File tools/oom_dump/README (right):
http://codereview.chromium.org/3170015/diff/2001/1004#newcode1
tools/oom_dump/README:1: oom_dump extracts useful information from OOM
minidump.
OOM minidumps -> Google Chrome OOM minidumps.
http://codereview.chromium.org/3170015/diff/2001/1004#newcode3
tools/oom_dump/README:3: To build one needs google-breakpad checkout
needs -> needs a
http://codereview.chromium.org/3170015/diff/2001/1004#newcode15
tools/oom_dump/README:15: put a soft line into /usr/lib directory).
line -> link
http://codereview.chromium.org/3170015/diff/2001/1006
File tools/oom_dump/oom_dump.cc (right):
http://codereview.chromium.org/3170015/diff/2001/1006#newcode72
tools/oom_dump/oom_dump.cc:72: u_int64_t array_ptr, int size,
Could you put one argument per line? Here and below.
http://codereview.chromium.org/3170015/diff/2001/1006#newcode262
tools/oom_dump/oom_dump.cc:262: printf(
The first argument will fit on the line here.
http://codereview.chromium.org/3170015/diff/2001/1006#newcode267
tools/oom_dump/oom_dump.cc:267: printf(
First argument will fit on the line.
http://codereview.chromium.org/3170015/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
