All comments addressed, thanks a lot for review, Mads, submitting.
Mark, if you have any comments, just let me know and I'll update files in a separate CL. http://codereview.chromium.org/3170015/diff/2001/1004 File tools/oom_dump/README (right): http://codereview.chromium.org/3170015/diff/2001/1004#newcode1 tools/oom_dump/README:1: oom_dump extracts useful information from OOM minidump. On 2010/08/14 10:54:41, Mads Ager wrote:
OOM minidumps -> Google Chrome OOM minidumps.
Done. http://codereview.chromium.org/3170015/diff/2001/1004#newcode3 tools/oom_dump/README:3: To build one needs google-breakpad checkout On 2010/08/14 10:54:41, Mads Ager wrote:
needs -> needs a
Done. http://codereview.chromium.org/3170015/diff/2001/1004#newcode15 tools/oom_dump/README:15: put a soft line into /usr/lib directory). On 2010/08/14 10:54:41, Mads Ager wrote:
line -> link
Done. http://codereview.chromium.org/3170015/diff/2001/1006 File tools/oom_dump/oom_dump.cc (right): http://codereview.chromium.org/3170015/diff/2001/1006#newcode72 tools/oom_dump/oom_dump.cc:72: u_int64_t array_ptr, int size, On 2010/08/14 10:54:41, Mads Ager wrote:
Could you put one argument per line? Here and below.
Done. http://codereview.chromium.org/3170015/diff/2001/1006#newcode262 tools/oom_dump/oom_dump.cc:262: printf( On 2010/08/14 10:54:41, Mads Ager wrote:
The first argument will fit on the line here.
Done. http://codereview.chromium.org/3170015/diff/2001/1006#newcode267 tools/oom_dump/oom_dump.cc:267: printf( On 2010/08/14 10:54:41, Mads Ager wrote:
First argument will fit on the line.
Done. http://codereview.chromium.org/3170015/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
