LGTM
http://codereview.chromium.org/3135022/diff/1/3 File src/frames.h (right): http://codereview.chromium.org/3135022/diff/1/3#newcode117 src/frames.h:117: enum Id { kIdMinValue = kMinInt, kIdMaxValue = kMaxInt, NO_ID = 0 }; There is a mix of camel case and all caps here. Could you check what the style guide says and make it consistent? http://codereview.chromium.org/3135022/diff/1/4 File src/objects.h (right): http://codereview.chromium.org/3135022/diff/1/4#newcode2768 src/objects.h:2768: kFlagsMinValue = kMinInt, kFlagsMaxValue = kMaxInt Will this fit on one line? Otherwise, please use one line per member. http://codereview.chromium.org/3135022/diff/1/5 File src/platform.h (right): http://codereview.chromium.org/3135022/diff/1/5#newcode367 src/platform.h:367: kLocalStorageKeyMinValue = kMinInt, kLocalStorageKeyMaxValue = kMaxInt One member per line? http://codereview.chromium.org/3135022/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
