http://codereview.chromium.org/3135022/diff/1/3 File src/frames.h (right):
http://codereview.chromium.org/3135022/diff/1/3#newcode117 src/frames.h:117: enum Id { kIdMinValue = kMinInt, kIdMaxValue = kMaxInt, NO_ID = 0 }; On 2010/08/16 16:32:30, Mads Ager wrote:
There is a mix of camel case and all caps here. Could you check what
the style
guide says and make it consistent?
There is a divergence in google/chromium style. Not sure what v8 is using though. The chromium coding style says: "Though the style guide says to use kConstantNaming for enums now, we still use MACRO_STYLE naming for enums for consistency with existing code." http://www.chromium.org/developers/coding-style But Google C++ style says: Enumerators should be named either like constants or like macros: either kEnumName or ENUM_NAME. http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Enumerator_Names#Enumerator_Names http://codereview.chromium.org/3135022/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
