LGTM. You may want to tweak the timeout settings on the build bots after
this
change is live.
http://codereview.chromium.org/3164023/diff/1/5
File test/mjsunit/testcfg.py (right):
http://codereview.chromium.org/3164023/diff/1/5#newcode94
test/mjsunit/testcfg.py:94: if self.self_script and (not
result.UnexpectedOutput()):
Maybe there should be an option to always unlink even when getting
unexpected output? Maybe add a helper on the result class
(HasPreciousOutput?) that uses this flag and UnexpectedOutput() to
compute whether or not we should throw the temporary script file away
(used in two places in the testcfg.py files).
http://codereview.chromium.org/3164023/diff/1/7
File test/sputnik/testcfg.py (right):
http://codereview.chromium.org/3164023/diff/1/7#newcode60
test/sputnik/testcfg.py:60: if not result.UnexpectedOutput():
self.tmpfile.Dispose()
result.HasPreciousOutput() instead of result.UnexpectedOutput() and add
flag so the build bots can always dispose the temporary files?
http://codereview.chromium.org/3164023/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
