Added flag and HasPreciousOutput to TestOutput Please take another look
http://codereview.chromium.org/3164023/diff/1/5 File test/mjsunit/testcfg.py (right): http://codereview.chromium.org/3164023/diff/1/5#newcode94 test/mjsunit/testcfg.py:94: if self.self_script and (not result.UnexpectedOutput()): On 2010/08/19 05:09:59, Kasper Lund wrote:
Maybe there should be an option to always unlink even when getting
unexpected
output? Maybe add a helper on the result class (HasPreciousOutput?)
that uses
this flag and UnexpectedOutput() to compute whether or not we should
throw the
temporary script file away (used in two places in the testcfg.py
files). Done. http://codereview.chromium.org/3164023/diff/1/7 File test/sputnik/testcfg.py (right): http://codereview.chromium.org/3164023/diff/1/7#newcode60 test/sputnik/testcfg.py:60: if not result.UnexpectedOutput(): self.tmpfile.Dispose() On 2010/08/19 05:09:59, Kasper Lund wrote:
result.HasPreciousOutput() instead of result.UnexpectedOutput() and
add flag so
the build bots can always dispose the temporary files?
Done. http://codereview.chromium.org/3164023/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
