comments applied
http://codereview.chromium.org/3247008/diff/1/3 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/3247008/diff/1/3#newcode975 src/arm/codegen-arm.cc:975: SaveRegisters(); // currently does nothing. On 2010/08/31 20:28:47, Erik Corry wrote:
Capitalize comments.
Done. http://codereview.chromium.org/3247008/diff/1/3#newcode1149 src/arm/codegen-arm.cc:1149: // Check that the *signed* result fits in a smi. On 2010/08/31 20:28:47, Erik Corry wrote:
You don't need this for AND or for the SAR if the shift is more than
0. Done. http://codereview.chromium.org/3247008/diff/1/3#newcode1185 src/arm/codegen-arm.cc:1185: // >>> 0 is the only case where the Smi is tagged. Comments updated. We only get here if the input were Smis, but the result of the operation cannot fit in a Smi. >>> 0 is a special case where the result is already tagged but wrong because the Smi is negative. We untag it before converting it. http://codereview.chromium.org/3247008/diff/1/3#newcode1487 src/arm/codegen-arm.cc:1487: // Smi tagging these two cases can only happen with shifts Punctuation error, "tagging" is connected to the sentence above. Comments updated. http://codereview.chromium.org/3247008/diff/1/4 File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/3247008/diff/1/4#newcode1355 src/arm/macro-assembler-arm.cc:1355: cmp(dest, Operand(LONG_MIN), ne); On 2010/08/31 20:28:47, Erik Corry wrote:
I wonder if it would be better to add a fudge factor and then do an
unsigned
comparison with 2? Conditional cmp seems like a tough instruction for
the CPU. Done. http://codereview.chromium.org/3247008/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
