LGTM.
http://codereview.chromium.org/3247008/diff/9001/10002 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/3247008/diff/9001/10002#newcode975 src/arm/codegen-arm.cc:975: SaveRegisters(); // Currently does nothing. I'm going to remove this, because it does nothing and it never will do anything. The register allocation logic is handled by the spillall below. http://codereview.chromium.org/3247008/diff/9001/10002#newcode1050 src/arm/codegen-arm.cc:1050: RestoreRegisters(); // Currently does nothing. The registers were restored by the MergeTo above. http://codereview.chromium.org/3247008/diff/9001/10002#newcode1165 src/arm/codegen-arm.cc:1165: // If the allocation fails, fall back to the GenericBinaryOpStub. I've added a comment here that we should really spill the registers before using r4, r5, r6. At the moment it doesn't matter since we don't use them. http://codereview.chromium.org/3247008/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
