Hi Rodolph, Thanks for your very good and valid comments! (Actually I should have caught these myself.) Hopefully it looks better now. In addition to fixing your comments I also changed one comment in the same file (code-stubs-arm.cc line 4154) that seems to have been wrong before. I also replaced 2 __ ldr with one __ Ldrd in StringCompareStub::Generate.
On Sep 3, 3:10 pm, [email protected] wrote: > http://codereview.chromium.org/3341012/diff/1/3 > File src/arm/code-stubs-arm.cc (right): > > http://codereview.chromium.org/3341012/diff/1/3#newcode4146 > src/arm/code-stubs-arm.cc:4146: __ ldrd(r6, r7, MemOperand(sp, > kToOffset)); > ldrd is a v5te instruction, V8 supports v4 so you need to provide code > for older architectures. The simplest way to do so is to use the Ldrd > macro instruction (macro-assembler-arm.*) which handle all this > transparently. Thanks! Fixed. > ldrd loads the lowest address in the lowest register so in effect your > code has swapped r6 and r7, you need to update the code after that. Fixed > http://codereview.chromium.org/3341012/show I hope I didn't send you double mails now. I was sure if you get the mails from the chromium code review tool automatically. Best Regards, Andreas -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
