New snapshot uploaded (Patch Set 4), to fix comment from Søren Gjesse.
Thanks
for the comment!
I hope it still looks ok for you Rodolph.
Regards,
Andreas Anyuru
On 2010/09/08 07:14:03, Søren Gjesse wrote:
Drive by comment
http://codereview.chromium.org/3341012/diff/9001/10002
File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/3341012/diff/9001/10002#newcode4146
src/arm/code-stubs-arm.cc:4146: // r6 = to (smi), r7 = from (smi)
Just a suggestion, but as r6 and r7 hold the same values throughout this
function using variables for the to and from registers
Register to = r6
Register from = r7
will make things easier to read, and you can avoid having to hassle with
keeping
comments in sync with the code.
I agree. Done.
http://codereview.chromium.org/3341012/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
