Nice idea Anton. LGTM.
http://codereview.chromium.org/3327021/diff/1/3 File src/global-handles.h (right): http://codereview.chromium.org/3327021/diff/1/3#newcode99 src/global-handles.h:99: static bool PostGarbageCollectionProcessing(); Document a return value here. http://codereview.chromium.org/3327021/diff/1/5 File src/heap.cc (right): http://codereview.chromium.org/3327021/diff/1/5#newcode701 src/heap.cc:701: // Note: as weak callbacks can execute arbitrary code, we cannot Please write a line about purpose of the loop below. Otherwise it's a bit confusing. http://codereview.chromium.org/3327021/diff/1/5#newcode705 src/heap.cc:705: int attempts = 7; Magic unnamed constants in the code. Consider giving name to 7 and moving it somewhere (e.g. into Heap class) http://codereview.chromium.org/3327021/diff/1/5#newcode722 src/heap.cc:722: if (collector == MARK_COMPACTOR) { Consider updating old gen limits inside loop as handles processing can trigger allocation and garbage collection. http://codereview.chromium.org/3327021/diff/1/6 File src/heap.h (right): http://codereview.chromium.org/3327021/diff/1/6#newcode693 src/heap.h:693: bool recollect_weakly_reachable = false); Consider using enumeration instead of boolean to make callsites more readable. http://codereview.chromium.org/3327021/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
