Thanks a lot for comments, Slava. May you have second look?
http://codereview.chromium.org/3327021/diff/1/3 File src/global-handles.h (right): http://codereview.chromium.org/3327021/diff/1/3#newcode99 src/global-handles.h:99: static bool PostGarbageCollectionProcessing(); On 2010/09/13 16:07:10, Vyacheslav Egorov wrote:
Document a return value here.
Done. http://codereview.chromium.org/3327021/diff/1/5 File src/heap.cc (right): http://codereview.chromium.org/3327021/diff/1/5#newcode701 src/heap.cc:701: // Note: as weak callbacks can execute arbitrary code, we cannot On 2010/09/13 16:07:10, Vyacheslav Egorov wrote:
Please write a line about purpose of the loop below. Otherwise it's a
bit
confusing.
Done. I would appreciate the second look. http://codereview.chromium.org/3327021/diff/1/5#newcode705 src/heap.cc:705: int attempts = 7; On 2010/09/13 16:07:10, Vyacheslav Egorov wrote:
Magic unnamed constants in the code. Consider giving name to 7 and
moving it
somewhere (e.g. into Heap class)
Almost done: I left the constant in the method itself---I don't think we should extend the scope of this constant right now. http://codereview.chromium.org/3327021/diff/1/5#newcode722 src/heap.cc:722: if (collector == MARK_COMPACTOR) { On 2010/09/13 16:07:10, Vyacheslav Egorov wrote:
Consider updating old gen limits inside loop as handles processing can
trigger
allocation and garbage collection.
Good catch, thanks. Done. http://codereview.chromium.org/3327021/diff/1/6 File src/heap.h (right): http://codereview.chromium.org/3327021/diff/1/6#newcode693 src/heap.h:693: bool recollect_weakly_reachable = false); On 2010/09/13 16:07:10, Vyacheslav Egorov wrote:
Consider using enumeration instead of boolean to make callsites more
readable. Done. I don't quite like the term "aggression", if you have any other ideas, they are most appreciated. http://codereview.chromium.org/3327021/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
