LGTM with a few comments:
http://codereview.chromium.org/3293002/diff/108002/109005 File src/full-codegen.h (right): http://codereview.chromium.org/3293002/diff/108002/109005#newcode250 src/full-codegen.h:250: static InlineFunctionGenerator kInlineFunctionGenerators[]; Strictly speaking the data members should be after all methods (cross platform). http://codereview.chromium.org/3293002/diff/108002/109011 File src/runtime.cc (right): http://codereview.chromium.org/3293002/diff/108002/109011#newcode10109 src/runtime.cc:10109: const int Runtime::kNotFound; I'm not sure you really need this. We don't usually have them from static consts defined in the header. http://codereview.chromium.org/3293002/diff/108002/109012 File src/runtime.h (right): http://codereview.chromium.org/3293002/diff/108002/109012#newcode476 src/runtime.h:476: // The number of arguments expected. nargs < 0 if the function takes nargs < 0 => Negative? http://codereview.chromium.org/3293002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
