The definition of the static const int member is removed from the
implementation
file.
http://codereview.chromium.org/3293002/diff/108002/109004
File src/full-codegen.cc (right):
http://codereview.chromium.org/3293002/diff/108002/109004#newcode513
src/full-codegen.cc:513: FullCodeGenerator::InlineFunctionGenerator
Added const qualifier.
http://codereview.chromium.org/3293002/diff/108002/109005
File src/full-codegen.h (right):
http://codereview.chromium.org/3293002/diff/108002/109005#newcode250
src/full-codegen.h:250: static InlineFunctionGenerator
kInlineFunctionGenerators[];
On 2010/09/14 13:45:36, Kasper Lund wrote:
Strictly speaking the data members should be after all methods (cross
platform).
This is a static const array, so it should be at the top of the section,
after typedefs. Added "const" to the declaration.
http://codereview.chromium.org/3293002/diff/108002/109011
File src/runtime.cc (right):
http://codereview.chromium.org/3293002/diff/108002/109011#newcode10109
src/runtime.cc:10109: const int Runtime::kNotFound;
On 2010/09/14 13:45:36, Kasper Lund wrote:
I'm not sure you really need this. We don't usually have them from
static consts
defined in the header.
The C++ standard seems to say this is needed unless every use of the
constant is in a place _requiring_ a compile-time constant.
http://codereview.chromium.org/3293002/diff/108002/109012
File src/runtime.h (right):
http://codereview.chromium.org/3293002/diff/108002/109012#newcode476
src/runtime.h:476: // The number of arguments expected. nargs < 0 if the
function takes
On 2010/09/14 13:45:36, Kasper Lund wrote:
nargs < 0 => Negative?
Done.
http://codereview.chromium.org/3293002/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
