LGTM if we can avoid the hairy stuff on ARM.
Thanks, Vitaly http://codereview.chromium.org/3357023/diff/9001/4010 File src/api.cc (right): http://codereview.chromium.org/3357023/diff/9001/4010#newcode2578 src/api.cc:2578: i::Isolate* isolate = self->GetHeap()->isolate(); You can now use self->GetIsolate() http://codereview.chromium.org/3357023/diff/9001/4011 File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/3357023/diff/9001/4011#newcode1925 src/arm/macro-assembler-arm.cc:1925: mov(r0, Operand(ExternalReference::isolate_address())); Please try using "ip" register here. http://codereview.chromium.org/3357023/diff/9001/4012 File src/arm/regexp-macro-assembler-arm.cc (right): http://codereview.chromium.org/3357023/diff/9001/4012#newcode63 src/arm/regexp-macro-assembler-arm.cc:63: * - Isolate* isolate (Address of the current isolate) nit: Align "(". http://codereview.chromium.org/3357023/diff/9001/4025 File src/v8.cc (right): http://codereview.chromium.org/3357023/diff/9001/4025#newcode108 src/v8.cc:108: // TODO: move lo and hi to isolate nit: Use TODO(isolates). http://codereview.chromium.org/3357023/diff/9001/4027 File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/3357023/diff/9001/4027#newcode2858 src/x64/macro-assembler-x64.cc:2858: // First six arguments are passed in registers on Linux/Mac. Linux/Mac -> other platforms. http://codereview.chromium.org/3357023/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
