Some code depends on ip staying the same after native calls. I found that
e.g.
GenericBinaryOpStub::HandleBinaryOpSlowCases would break if I used ip as a
scratch register in CallCFunction. As an alternative we could try to pass a
scratch register as an argument to CallCFunction but that would differ from
what
we do on the other platforms.
http://codereview.chromium.org/3357023/diff/9001/4010
File src/api.cc (right):
http://codereview.chromium.org/3357023/diff/9001/4010#newcode2578
src/api.cc:2578: i::Isolate* isolate = self->GetHeap()->isolate();
On 2010/09/14 17:59:33, Vitaly wrote:
You can now use self->GetIsolate()
Done.
http://codereview.chromium.org/3357023/diff/9001/4012
File src/arm/regexp-macro-assembler-arm.cc (right):
http://codereview.chromium.org/3357023/diff/9001/4012#newcode63
src/arm/regexp-macro-assembler-arm.cc:63: * - Isolate* isolate
(Address of the current isolate)
On 2010/09/14 17:59:33, Vitaly wrote:
nit: Align "(".
Done.
http://codereview.chromium.org/3357023/diff/9001/4025
File src/v8.cc (right):
http://codereview.chromium.org/3357023/diff/9001/4025#newcode108
src/v8.cc:108: // TODO: move lo and hi to isolate
On 2010/09/14 17:59:33, Vitaly wrote:
nit: Use TODO(isolates).
Done.
http://codereview.chromium.org/3357023/diff/9001/4027
File src/x64/macro-assembler-x64.cc (right):
http://codereview.chromium.org/3357023/diff/9001/4027#newcode2858
src/x64/macro-assembler-x64.cc:2858: // First six arguments are passed
in registers on Linux/Mac.
On 2010/09/14 17:59:33, Vitaly wrote:
Linux/Mac -> other platforms.
Done.
http://codereview.chromium.org/3357023/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
