LGTM with a few nits.
http://codereview.chromium.org/3382007/diff/4001/5002 File src/heap.cc (right): http://codereview.chromium.org/3382007/diff/4001/5002#newcode819 src/heap.cc:819: ScavengeVisitor(Heap* heap) : heap_(heap) {} nit: "explicit" http://codereview.chromium.org/3382007/diff/4001/5002#newcode835 src/heap.cc:835: Heap* heap_; nit: Insert a blank line before the field. http://codereview.chromium.org/3382007/diff/4001/5003 File src/isolate.h (right): http://codereview.chromium.org/3382007/diff/4001/5003#newcode1104 src/isolate.h:1104: StackLimitCheck(Isolate* isolate) : isolate_(isolate) { } nit: "explicit" http://codereview.chromium.org/3382007/diff/4001/5011 File src/spaces.h (right): http://codereview.chromium.org/3382007/diff/4001/5011#newcode352 src/spaces.h:352: Heap* heap; I know this class is already inconsistent in this regard, but this field should be named "heap_". http://codereview.chromium.org/3382007/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
